0a72695844
Fixes issues with offloading to WED, especially with VLAN bridges involved Signed-off-by: Felix Fietkau <nbd@nbd.name>
28 lines
1004 B
Diff
28 lines
1004 B
Diff
From: Lorenzo Bianconi <lorenzo@kernel.org>
|
|
Date: Mon, 18 Jul 2022 11:51:53 +0200
|
|
Subject: [PATCH] net: ethernet: mtk_ppe: fix possible NULL pointer dereference
|
|
in mtk_flow_get_wdma_info
|
|
|
|
odev pointer can be NULL in mtk_flow_offload_replace routine according
|
|
to the flower action rules. Fix possible NULL pointer dereference in
|
|
mtk_flow_get_wdma_info.
|
|
|
|
Fixes: a333215e10cb5 ("net: ethernet: mtk_eth_soc: implement flow offloading to WED devices")
|
|
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
|
|
Link: https://lore.kernel.org/r/4e1685bc4976e21e364055f6bee86261f8f9ee93.1658137753.git.lorenzo@kernel.org
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
|
|
--- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
|
|
+++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c
|
|
@@ -93,6 +93,9 @@ mtk_flow_get_wdma_info(struct net_device
|
|
};
|
|
struct net_device_path path = {};
|
|
|
|
+ if (!ctx.dev)
|
|
+ return -ENODEV;
|
|
+
|
|
memcpy(ctx.daddr, addr, sizeof(ctx.daddr));
|
|
|
|
if (!IS_ENABLED(CONFIG_NET_MEDIATEK_SOC_WED))
|