20ea6adbf1
Build system: x86_64 Build-tested: bcm2708, bcm2709, bcm2710, bcm2711 Run-tested: bcm2708/RPiB+, bcm2709/RPi3B, bcm2710/RPi3B, bcm2711/RPi4B Signed-off-by: Marty Jones <mj8263788@gmail.com> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
28 lines
1005 B
Diff
28 lines
1005 B
Diff
From f15d0b837549943a865c9d990d1d07710f3635e9 Mon Sep 17 00:00:00 2001
|
|
From: Phil Elwell <phil@raspberrypi.org>
|
|
Date: Wed, 12 Jun 2019 17:15:05 +0100
|
|
Subject: [PATCH] w1: w1-gpio: Make GPIO an output for strong pullup
|
|
|
|
The logic to drive the data line high to implement a strong pullup
|
|
assumed that the pin was already an output - setting a value does
|
|
not change an input.
|
|
|
|
See: https://github.com/raspberrypi/firmware/issues/1143
|
|
|
|
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
|
|
---
|
|
drivers/w1/masters/w1-gpio.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/w1/masters/w1-gpio.c
|
|
+++ b/drivers/w1/masters/w1-gpio.c
|
|
@@ -30,7 +30,7 @@ static u8 w1_gpio_set_pullup(void *data,
|
|
* This will OVERRIDE open drain emulation and force-pull
|
|
* the line high for some time.
|
|
*/
|
|
- gpiod_set_raw_value(pdata->gpiod, 1);
|
|
+ gpiod_direction_output_raw(pdata->gpiod, 1);
|
|
msleep(pdata->pullup_duration);
|
|
/*
|
|
* This will simply set the line as input since we are doing
|