20ea6adbf1
Build system: x86_64 Build-tested: bcm2708, bcm2709, bcm2710, bcm2711 Run-tested: bcm2708/RPiB+, bcm2709/RPi3B, bcm2710/RPi3B, bcm2711/RPi4B Signed-off-by: Marty Jones <mj8263788@gmail.com> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
29 lines
1.0 KiB
Diff
29 lines
1.0 KiB
Diff
From 8e878b9ef7d6078e5facad9ebc0eacca9cbe3688 Mon Sep 17 00:00:00 2001
|
|
From: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
Date: Wed, 29 Apr 2020 22:05:09 +0100
|
|
Subject: [PATCH] media: bcm2835-unicam: Do not stop streaming in
|
|
unicam_release
|
|
|
|
unicam_release calls _vb2_fop_release, which will call stop_streaming
|
|
if that particular node was streaming. Calling it unconditionally (as
|
|
the code was) means that if a second handle was opened eg to alter
|
|
a setting, on closing that connection it also stopped Unicam.
|
|
|
|
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
|
|
---
|
|
drivers/media/platform/bcm2835/bcm2835-unicam.c | 3 ---
|
|
1 file changed, 3 deletions(-)
|
|
|
|
--- a/drivers/media/platform/bcm2835/bcm2835-unicam.c
|
|
+++ b/drivers/media/platform/bcm2835/bcm2835-unicam.c
|
|
@@ -2204,9 +2204,6 @@ static int unicam_release(struct file *f
|
|
if (fh_singular)
|
|
v4l2_subdev_call(sd, core, s_power, 0);
|
|
|
|
- if (node->streaming)
|
|
- unicam_stop_streaming(&node->buffer_queue);
|
|
-
|
|
node->open--;
|
|
mutex_unlock(&node->lock);
|
|
|