![Christian Marangi](/assets/img/avatar_default.png)
Backport upstream code split patch for qca8k needed for ipq40xx target to correctly implement a DSA driver. Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
29 lines
1.0 KiB
Diff
29 lines
1.0 KiB
Diff
From c3664d913dc115cab4a5fdb5634df4887048000e Mon Sep 17 00:00:00 2001
|
|
From: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Date: Fri, 4 Feb 2022 13:03:36 +0300
|
|
Subject: [PATCH 1/1] net: dsa: qca8k: check correct variable in
|
|
qca8k_phy_eth_command()
|
|
|
|
This is a copy and paste bug. It was supposed to check "clear_skb"
|
|
instead of "write_skb".
|
|
|
|
Fixes: 2cd548566384 ("net: dsa: qca8k: add support for phy read/write with mgmt Ethernet")
|
|
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/dsa/qca8k.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
--- a/drivers/net/dsa/qca8k.c
|
|
+++ b/drivers/net/dsa/qca8k.c
|
|
@@ -1018,7 +1018,7 @@ qca8k_phy_eth_command(struct qca8k_priv
|
|
|
|
clear_skb = qca8k_alloc_mdio_header(MDIO_WRITE, QCA8K_MDIO_MASTER_CTRL, &clear_val,
|
|
QCA8K_ETHERNET_PHY_PRIORITY, sizeof(clear_val));
|
|
- if (!write_skb) {
|
|
+ if (!clear_skb) {
|
|
ret = -ENOMEM;
|
|
goto err_clear_skb;
|
|
}
|