30d2fcffeb
The prerequisite DSA changes for the nice RTL8366RB improvements are already backported so bring back these changes as well. Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
52 lines
1.8 KiB
Diff
52 lines
1.8 KiB
Diff
From ddb59a5dc42714999c335dab4bf256125ba3120c Mon Sep 17 00:00:00 2001
|
|
From: Linus Walleij <linus.walleij@linaro.org>
|
|
Date: Sun, 26 Sep 2021 00:59:29 +0200
|
|
Subject: [PATCH 06/11] net: dsa: rtl8366: Drop and depromote pointless prints
|
|
MIME-Version: 1.0
|
|
Content-Type: text/plain; charset=UTF-8
|
|
Content-Transfer-Encoding: 8bit
|
|
|
|
We don't need a message for every VLAN association, dbg
|
|
is fine. The message about adding the DSA or CPU
|
|
port to a VLAN is directly misleading, this is perfectly
|
|
fine.
|
|
|
|
Cc: Vladimir Oltean <olteanv@gmail.com>
|
|
Cc: Mauri Sandberg <sandberg@mailfence.com>
|
|
Cc: DENG Qingfang <dqfext@gmail.com>
|
|
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
|
|
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
|
|
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
|
|
Signed-off-by: David S. Miller <davem@davemloft.net>
|
|
---
|
|
drivers/net/dsa/rtl8366.c | 11 ++++-------
|
|
1 file changed, 4 insertions(+), 7 deletions(-)
|
|
|
|
--- a/drivers/net/dsa/rtl8366.c
|
|
+++ b/drivers/net/dsa/rtl8366.c
|
|
@@ -318,12 +318,9 @@ int rtl8366_vlan_add(struct dsa_switch *
|
|
return ret;
|
|
}
|
|
|
|
- dev_info(smi->dev, "add VLAN %d on port %d, %s, %s\n",
|
|
- vlan->vid, port, untagged ? "untagged" : "tagged",
|
|
- pvid ? " PVID" : "no PVID");
|
|
-
|
|
- if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
|
|
- dev_err(smi->dev, "port is DSA or CPU port\n");
|
|
+ dev_dbg(smi->dev, "add VLAN %d on port %d, %s, %s\n",
|
|
+ vlan->vid, port, untagged ? "untagged" : "tagged",
|
|
+ pvid ? "PVID" : "no PVID");
|
|
|
|
member |= BIT(port);
|
|
|
|
@@ -356,7 +353,7 @@ int rtl8366_vlan_del(struct dsa_switch *
|
|
struct realtek_smi *smi = ds->priv;
|
|
int ret, i;
|
|
|
|
- dev_info(smi->dev, "del VLAN %04x on port %d\n", vlan->vid, port);
|
|
+ dev_dbg(smi->dev, "del VLAN %d on port %d\n", vlan->vid, port);
|
|
|
|
for (i = 0; i < smi->num_vlan_mc; i++) {
|
|
struct rtl8366_vlan_mc vlanmc;
|